-
Notifications
You must be signed in to change notification settings - Fork 79
Conversation
…put form `docker build`
This reverts commit 5a32efa.
They have no UI though. This is just the backend.
@jonborchardt, this currently stalls out when trying to read the response from the tasks service, as expected. The format is actually defined in tugboat, not here. |
Maybe we should move the definition to back to the AllenNLP demo. I'm not sure it makes sense to live in Tugboat, given it's an AllenNLP specific thing. @jonborchardt what do you think? |
@dirkgr I'm not seeing an error when I pull this down and run things locally...but the examples for RC appear to be in the same order as they're in now. So either I'm doing something wrong, or there's an uncommitted change or some other ghost in the machine somewhere in the mix? |
Sorry, I had some untracked files in the directory. |
This adds support to the UI for the new example format, which required updating to `@allenai/varnish@2.0.0` and patching some related code.
I ran this just now and it worked right away. I don't know why I thought it was broken before. Will now try to orchestrate the reviews across three repos 🤪. |
I'm getting this Cypress error. Apparently it can't find the description for reading comprehension tasks in the output of the main page. When I |
Did the text change? The test loads the page in a browser, and looks for the text that's defined here. If the text is present but this isn't finding it, then something else is wrong. If the text changed we might just need to update I'll try this out shortly and let you know what I figure out. |
It appears to be something that's CI specific, as they work locally. I cut #903, someone from ReViz will look into this next week, but for now it's ok to ignore the failures as they're spurious. |
Sweet, it's live and it works! |
This makes it so examples for the reading comprehension tasks are ordered the way they appear in the tasks file. At least, that's what it'll do when it's done.
This is part of a multi-repo nightmare. We need
all at the same time.